fix: update page validation to allow zero as a valid page number#402
Open
fix: update page validation to allow zero as a valid page number#402
Conversation
Contributor
aazizali
commented
Jul 8, 2025
aazizali
commented
- update page validation to allow zero as a valid page number
|
|
albeortega
approved these changes
Jul 8, 2025
albeortega
reviewed
Jul 8, 2025
| @@ -25,7 +25,7 @@ public class PageInformation { | |||
| * The page requested of the results. | |||
| * Must be greater than or equal to 1. | |||
Contributor
There was a problem hiding this comment.
Hi @aazizali Please update the above comment "Must be greater than or equal to 1." to have 0.
Signed-off-by: Aziz Ali (aali114) <[email protected]>
aazizali
force-pushed
the
bugfix/update-page-validation-allow-zero-page-number
branch
from
ca7a8cb to
2020046
Compare
adgonz90
approved these changes
Jul 9, 2025
adgonz90
requested changes
Jul 9, 2025
| * Must be greater than or equal to 0. | ||
| */ | ||
| @Min(value = 1) | ||
| @Min(value = 0) |
Collaborator
There was a problem hiding this comment.
Please review response logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.