fix(vt): tokenize --title-mode args correctly for fwd parser#602
Open
nikolasdehor wants to merge 1 commit intoamantus-ai:mainfrom
Open
fix(vt): tokenize --title-mode args correctly for fwd parser#602nikolasdehor wants to merge 1 commit intoamantus-ai:mainfrom
nikolasdehor wants to merge 1 commit intoamantus-ai:mainfrom
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Pull request overview
Fixes web/bin/vt argument forwarding so --title-mode <mode> is passed to the forwarder as two separate argv tokens (instead of a single merged token), matching what downstream parsers expect.
Changes:
- Convert
TITLE_MODE_ARGSfrom a string to a bash array and expand it via"${TITLE_MODE_ARGS[@]}"at all forwarder call sites. - Update
exec_fwdinvocations in direct execution and shell-wrapped execution paths to use the array expansion. - Add an integration test (
vt-command.test.ts) that asserts forwarded argv tokenization for--title-mode.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| web/bin/vt | Switches --title-mode forwarding to array-based argv expansion to prevent token merging. |
| web/src/test/integration/vt-command.test.ts | Adds an integration test that captures forwarded argv and verifies --title-mode is tokenized correctly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
web/bin/vtto pass--title-modeas separate argv tokensTITLE_MODE_ARGSfrom string to array expansion ("${TITLE_MODE_ARGS[@]}")vt-command.test.ts)Why
Issue #568 reports that
vt --title-mode <mode> ...was forwarded as a single argv token ("--title-mode dynamic"), so downstream parsers could not consume it correctly.Validation
cd web && pnpm exec vitest run src/test/integration/vt-command.test.ts✅cd web && ./scripts/test-vt-syntax.sh✅Notes
Full
pnpm run checkon current upstreammainstill fails due unrelated pre-existing merge artifacts/regressions (handled separately in #601).Closes #568