Skip to content

fix(vt): tokenize --title-mode args correctly for fwd parser#602

Open
nikolasdehor wants to merge 1 commit intoamantus-ai:mainfrom
nikolasdehor:fix/vt-title-mode-argv-tokenization
Open

fix(vt): tokenize --title-mode args correctly for fwd parser#602
nikolasdehor wants to merge 1 commit intoamantus-ai:mainfrom
nikolasdehor:fix/vt-title-mode-argv-tokenization

Conversation

@nikolasdehor
Copy link
Copy Markdown

Summary

  • fix web/bin/vt to pass --title-mode as separate argv tokens
  • switch TITLE_MODE_ARGS from string to array expansion ("${TITLE_MODE_ARGS[@]}")
  • keep existing wrapper behavior while preventing token merging bugs
  • add integration test to validate argv tokenization (vt-command.test.ts)

Why

Issue #568 reports that vt --title-mode <mode> ... was forwarded as a single argv token ("--title-mode dynamic"), so downstream parsers could not consume it correctly.

Validation

  • cd web && pnpm exec vitest run src/test/integration/vt-command.test.ts
  • cd web && ./scripts/test-vt-syntax.sh

Notes

Full pnpm run check on current upstream main still fails due unrelated pre-existing merge artifacts/regressions (handled separately in #601).

Closes #568

Copilot AI review requested due to automatic review settings February 23, 2026 02:00
@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes web/bin/vt argument forwarding so --title-mode <mode> is passed to the forwarder as two separate argv tokens (instead of a single merged token), matching what downstream parsers expect.

Changes:

  • Convert TITLE_MODE_ARGS from a string to a bash array and expand it via "${TITLE_MODE_ARGS[@]}" at all forwarder call sites.
  • Update exec_fwd invocations in direct execution and shell-wrapped execution paths to use the array expansion.
  • Add an integration test (vt-command.test.ts) that asserts forwarded argv tokenization for --title-mode.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
web/bin/vt Switches --title-mode forwarding to array-based argv expansion to prevent token merging.
web/src/test/integration/vt-command.test.ts Adds an integration test that captures forwarded argv and verifies --title-mode is tokenized correctly.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vt --title-mode <mode> … passes as single argv token, so fwd parser doesn’t consume it (v1.0.0-beta.15)

2 participants