fix: preserve quotes in session commands by using formatCommand#591
Open
Ilakiancs wants to merge 1 commit intoamantus-ai:mainfrom
Open
fix: preserve quotes in session commands by using formatCommand#591Ilakiancs wants to merge 1 commit intoamantus-ai:mainfrom
Ilakiancs wants to merge 1 commit intoamantus-ai:mainfrom
Conversation
This fixes a bug where arguments with quotes (like 'echo -s "hello world"') were being stripped of quotes when falling back to shell execution, causing them to be split into multiple arguments.
|
Opened an alternative minimal-scope fix PR: #603.\n\nIt keeps file layout intact and updates shell fallback paths to preserve argument boundaries via POSIX-safe quoting, with unit tests for spaces and single quotes. |
|
Opened an alternative minimal-scope fix PR: #603. It keeps file layout intact and updates |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug where arguments with quotes (like 'echo -s "hello world"') were being stripped of quotes when falling back to shell execution, causing them to be split into multiple arguments.