create a column alias for COUNT(*) so that optional SQL::Abstract::More column quoting works#24
Open
djerius wants to merge 2 commits intoalranel:masterfrom
Open
create a column alias for COUNT(*) so that optional SQL::Abstract::More column quoting works#24djerius wants to merge 2 commits intoalranel:masterfrom
djerius wants to merge 2 commits intoalranel:masterfrom
Conversation
…re column quoting works
The existing code passes the expression COUNT(*) to SQL::Abstract::More, which
intepreted it as a column name and if its quote_char option was set, quoted it,
leading to errors such as
DBD::Pg::st execute failed: ERROR: column "COUNT(*)" does not exist
LINE 1: SELECT "COUNT(*)" FROM "temp0002" AS "me"
^ [for Statement "SELECT "COUNT(*)" FROM "temp0002" AS "me""]
This commit creates a column alias for COUNT(*), providing something appropriate for
SQL::Abstract::More to quote.
djerius
force-pushed
the
issue-23-fix-count-sql
branch
from
b793c09 to
453c8e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing code passes the expression COUNT(*) to SQL::Abstract::More, which intepreted it as a column name and if its quote_char option was set, quoted it, leading to errors such as
DBD::Pg::st execute failed: ERROR: column "COUNT()" does not exist LINE 1: SELECT "COUNT()" FROM "temp0002" AS "me"
^ [for Statement "SELECT "COUNT(*)" FROM "temp0002" AS "me""]
This commit creates a column alias for COUNT(*), providing something appropriate for SQL::Abstract::More to quote.