Fix JSON struct tag parsing to handle modifiers#7
Open
krismcfarlin wants to merge 2 commits intoalpkeskin:mainfrom
Open
Fix JSON struct tag parsing to handle modifiers#7krismcfarlin wants to merge 2 commits intoalpkeskin:mainfrom
krismcfarlin wants to merge 2 commits intoalpkeskin:mainfrom
Conversation
- Skip fields starting with underscore during struct normalization - Reduces output size by 75% (517K -> 127K chars in test case) - Filters internal database fields (_id, _createdDate, _email, _updatedDate) - Aligns with common convention of underscore prefix for private/internal fields
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes parsing of JSON struct tags to properly extract field names before comma-separated modifiers like
,omitemptyand,inline.This allows TOON to correctly handle Go structs with:
json:\",inline\")json:\"fieldname,omitempty\")Changes:
Problem:
The current implementation reads the entire JSON tag value including modifiers as the field name. For example:
json:\",inline\"was being used as field name\",inline\"json:\"field,omitempty\"was being used as field name\"field,omitempty\"Solution:
Split the tag on comma and use only the portion before the first comma as the field name. Special handling for inline fields (empty name) to merge nested struct contents into parent.
Testing:
Tested with structs containing various tag modifiers and confirmed proper field name extraction and inline embedding behavior.