Merged
Conversation
Benjamin-Freoua-Alma
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change
Linear task
When BusinessEventsService::onOrderConfirmed() threw a BusinessEventsServiceException, it was propagated as a GatewayServiceException from GatewayService::woocommerceOrderStatusChanged(), blocking the WooCommerce order status change flow.
Code changes
Catch & log instead of throw: GatewayService now catches BusinessEventsServiceException and logs it as a debug message instead of re-throwing it as a GatewayServiceException.
Make LoggerService a required dependency: Removed nullable ?LoggerService with NullLogger fallback across 7 classes. LoggerService is now a required constructor parameter, enforcing proper DI.
Fix missing LoggerService in ConfigFormMapper: Added LoggerService injection to ConfigFormMapper so it can pass it to FeePlanConfiguration (which now requires it).
Fixed FeePlanConfigurationTest, FeePlanProviderTest, ConfigFormMapperTest to pass LoggerService mock.
Created GatewayServiceTest with 3 tests covering the new behavior (exception logged, success case, order not found).
How to test
As a reviewer, you are encouraged to test the PR locally.
Checklist for authors and reviewers
Non applicable