Fix _handle_sentence merging adjacent BIO entities#570
Open
Chessing234 wants to merge 1 commit intoallenai:mainfrom
Open
Fix _handle_sentence merging adjacent BIO entities#570Chessing234 wants to merge 1 commit intoallenai:mainfrom
Chessing234 wants to merge 1 commit intoallenai:mainfrom
Conversation
When two entities are adjacent (no O token between them), a B- tag following an I- or B- tag was silently treated as a continuation of the current entity. The fix closes the current entity before starting a new one when a B- tag is encountered mid-entity. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_handle_sentenceindata_util.pyparses BIO-tagged NER data into spaCy entity spans. When two entities are adjacent (noOtoken between them), aB-tag is silently treated as a continuation of the current entity instead of starting a new one.Root cause: The condition
if in_entity: passdoes not distinguishI-(continuation) fromB-(new entity start). Any non-Otag while inside an entity is ignored.Example:
(0, 12, "ORGAN")covering "brain cancer"(0, 5, "ORGAN")and(6, 12, "TUMOR")Fix: When a
B-tag is encountered mid-entity, close the current entity and start a new one.I-tags continue to extend the current entity as before.Test plan
🤖 Generated with Claude Code