Fix Map zone gather race for async process-type tasks#776
Draft
GeigerJ2 wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update_map_task_stateaggregated outputs by iterating over the gather_item's own clones, but for async process-type source tasks (CalcJob, WorkChain, @task.graph) the awaitable callback cascade can finish all mapped source tasks and reach the gather phase beforecontinue_workgraphhas scheduled the gather_item clones. The missing clone results caused aKeyErroror left clones stuck in PLANNED, hanging the engine's finalize path.Two changes fix this:
generate_mapped_tasksnow skips cloning gather_item entirely. The gather_item executor is a pure pass-through (return_input), so no per-item clone is needed. Skipping it also removes the PLANNED-clone hang.update_map_task_statereads results directly from each mapped source task's clones (viasource_task.mapped_tasks) instead of from gather_item clones. This is semantically equivalent and race-free because source task results are populated byupdate_task_statebefore the cascade can reach the gather phase.