handleSubscriptionPacket - topic calc error#233
Merged
Conversation
Member
|
@tyeth Have you tested this on IO Prod? Have you tested it with topics other than I2C? |
brentru
requested changes
Sep 2, 2025
Member
brentru
left a comment
brentru
left a comment
There was a problem hiding this comment.
This looks good and addresses 2.2.3 of the MQTT 3.1.1 spec. Additionally, after glancing at your PRs, it looks like the bug has been fixed, which is great.
I am requesting one change, please tag me when done
tyeth
added a commit
to adafruit/Adafruit_Wippersnapper_Arduino
that referenced
this pull request
Sep 3, 2025
Member
Author
Just to confirm, yes I did test it with some other components being added. Again from CI this morning, against Prod, adding neopixel strands to a qtpy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the topic length and start calculation according to the mqtt3.1 spec, it turns out there's a similar calculation in the readFullPacket code (L297).