Stop using reserved words without quotes during jq usage#2
Open
tjgurwara99 wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to make the action’s jq invocations compatible with older jq versions (<= 1.6) by avoiding unquoted reserved keywords in object construction, specifically for the label field used when generating the request body for the code coverage API.
Changes:
- Quote the
"label"JSON key in thejq -nobject construction for both PR-based and ref-based uploads.
Show a summary per file
| File | Description |
|---|---|
action.yml |
Updates the jq JSON body construction to quote the "label" key. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comments suppressed due to low confidence (1)
action.yml:95
- Same issue here as above:
--arg label ...introduces$label, which is a reserved keyword in older jq versions (<=1.6). Quoting the object key doesn't avoid the reserved-word restriction on variable names; rename the jq variable and reference the new name.
--rawfile coverage_report __coverage_b64.txt \
--arg language_name "$INPUT_LANGUAGE" \
--arg label "$INPUT_LABEL" \
'{commit_oid: $commit_oid, ref: $ref, coverage_report: $coverage_report, language_name: $language_name, "label": $label}' \
- Files reviewed: 1/1 changed files
- Comments generated: 1
Comment on lines
81
to
+85
| --rawfile coverage_report __coverage_b64.txt \ | ||
| --arg language_name "$INPUT_LANGUAGE" \ | ||
| --arg label "$INPUT_LABEL" \ | ||
| --argjson pr_number "$PR_NUMBER" \ | ||
| '{commit_oid: $commit_oid, coverage_report: $coverage_report, language_name: $language_name, label: $label, pull_request_number: $pr_number}' \ | ||
| '{commit_oid: $commit_oid, coverage_report: $coverage_report, language_name: $language_name, "label": $label, pull_request_number: $pr_number}' \ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1