Skip to content

Stop using reserved words without quotes during jq usage#2

Open
tjgurwara99 wants to merge 1 commit into
mainfrom
tjgurwara99/fix-use-of-reserved-words
Open

Stop using reserved words without quotes during jq usage#2
tjgurwara99 wants to merge 1 commit into
mainfrom
tjgurwara99/fix-use-of-reserved-words

Conversation

@tjgurwara99
Copy link
Copy Markdown
Collaborator

Closes #1

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to make the action’s jq invocations compatible with older jq versions (<= 1.6) by avoiding unquoted reserved keywords in object construction, specifically for the label field used when generating the request body for the code coverage API.

Changes:

  • Quote the "label" JSON key in the jq -n object construction for both PR-based and ref-based uploads.
Show a summary per file
File Description
action.yml Updates the jq JSON body construction to quote the "label" key.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comments suppressed due to low confidence (1)

action.yml:95

  • Same issue here as above: --arg label ... introduces $label, which is a reserved keyword in older jq versions (<=1.6). Quoting the object key doesn't avoid the reserved-word restriction on variable names; rename the jq variable and reference the new name.
            --rawfile coverage_report __coverage_b64.txt \
            --arg language_name "$INPUT_LANGUAGE" \
            --arg label "$INPUT_LABEL" \
            '{commit_oid: $commit_oid, ref: $ref, coverage_report: $coverage_report, language_name: $language_name, "label": $label}' \
  • Files reviewed: 1/1 changed files
  • Comments generated: 1

Comment thread action.yml
Comment on lines 81 to +85
--rawfile coverage_report __coverage_b64.txt \
--arg language_name "$INPUT_LANGUAGE" \
--arg label "$INPUT_LABEL" \
--argjson pr_number "$PR_NUMBER" \
'{commit_oid: $commit_oid, coverage_report: $coverage_report, language_name: $language_name, label: $label, pull_request_number: $pr_number}' \
'{commit_oid: $commit_oid, coverage_report: $coverage_report, language_name: $language_name, "label": $label, pull_request_number: $pr_number}' \
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Older versions of jq in the runner break this action

2 participants