Skip to content

ci: test against symfony/http-client 5.3.12 as lowest#125

Merged
ackintosh merged 1 commit intoackintosh:masterfrom
marmichalski:sf-client
Feb 8, 2025
Merged

ci: test against symfony/http-client 5.3.12 as lowest#125
ackintosh merged 1 commit intoackintosh:masterfrom
marmichalski:sf-client

Conversation

@marmichalski
Copy link
Copy Markdown
Contributor

This should fix the failing PHP 8.4 pipeline with lowest deps.

I believe we could just drop such outdated packages from composer in general 👀

@marmichalski marmichalski marked this pull request as ready for review January 27, 2025 20:38
@coveralls
Copy link
Copy Markdown

coveralls commented Jan 27, 2025

Coverage Status

coverage: 92.647%. remained the same
when pulling 1021b21 on marmichalski:sf-client
into 24dcfb8 on ackintosh:master.

@marmichalski
Copy link
Copy Markdown
Contributor Author

marmichalski commented Jan 27, 2025

Only my enemy, memcached, did not pass, as I have failed to fix it properly in #124. PHP 8.4 passed though 😊

@ackintosh ackintosh merged commit dffbbcd into ackintosh:master Feb 8, 2025
@ackintosh
Copy link
Copy Markdown
Owner

Merged, thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants