Open
Conversation
Replace HashMap with LinkedHashMap for deterministic insertion
5afeb6f to
79094b6
Compare
when seeding use rand_chacha for reproducible output across platforms
|
I'd like this to be merged, as I'm also interested in this feature. How could I contribute to this happening? |
aatxe
approved these changes
Sep 16, 2023
Owner
|
The change looks fine to me, but we need to move the project over to GitHub Actions since it's still waiting for TravisCI which was killed long ago. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a project I need to be able to reproduce the same generation multiple times so I've implemented a way to seed the random number generator, or provide your own generator.
If there is interest in merging such functionality.
Add
rand::Rngargument toStatestraitnext()function.Rename
generatetogenerate_basewhich now takes an argument that implementsrand::RngRename
generate_from_tokentogenerate_from_token_basewhich now takes an argument that implementsrand::RngAdd new
generateandgenerate_from_tokenfunctions that call the base functions withthread_rng().Add the following seedable generate functions
generate_with_seed(seed: u64)generate_with_rng<R: rand::Rng>(rng: R)generate_from_token_with_seed(token: T, seed: u64)generate_from_token_with_rng<R: rand::Rng>(token: T, rng: R)Implement linked-hash-map for predictable hashmap insertion.
Add "seedable" feature