Open
Conversation
Author
|
There's one test in |
JesusMcCloud
requested changes
Jan 26, 2026
Collaborator
JesusMcCloud
left a comment
JesusMcCloud
left a comment
There was a problem hiding this comment.
Looks really good! Much simpler Code and it still seems impossible to wire sealed boxes, algorithms and keys in an illegal way. I do need to tinker with it a bit in my IDE, to double-check. @iaik-jheher what is your take on this?
...ble/src/commonMain/kotlin/at/asitplus/signum/indispensable/pki/generalNames/IPAddressName.kt
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The key trick is to use
SymmetricEncryptionAlgorithmto hold the type parameters (i.e. Auth and Nonce). Then, the sealed hierarchies no longer rely on interfaces, instead, they provide extensions thatwhenover the relevant inheritors, and useabsurdwhen an inheritor cannot possibly be called on this method.