Fix: Managing the availability of the clear logs button on Log page#4836
Open
IgorA100 wants to merge 4 commits into
Open
Fix: Managing the availability of the clear logs button on Log page#4836IgorA100 wants to merge 4 commits into
IgorA100 wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines the Log page clear-logs button state so users cannot repeatedly trigger log deletion while the modal or table refresh is in progress.
Changes:
- Disables the clear-logs button immediately after it is clicked.
- Re-checks selected rows after table load success and AJAX modal-loading failures.
- Extracts clear button enable/disable logic into
manageClearButtonAvailability().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
…ng the "#clearLogsConfirmBtn" button. The issue was related to an unnecessary call to manageClearButtonAvailability() (log.js)
Contributor
Author
|
@connortechnology |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The delete logs button now remains active even after deleting logs (both successful and unsuccessful).
This PR allows for more accurate management of the button's availability.