Allow tag names in languages other than English & Bump version to 1.39.6#4779
Allow tag names in languages other than English & Bump version to 1.39.6#4779IgorA100 wants to merge 13 commits into
Conversation
IgorA100
changed the title
|
I hope this PR will work. |
|
Just wondering if we sholdn't do something more significant. Why isn't it using the right collation to begin with? I've seen this because my db is really old, and I had to convert it to utf8mb4. Have had to do it to many installs over the years. Just wondering if we need to change your entire db and not just the table. What was the collation before? |
There was a problem hiding this comment.
Pull request overview
Bumps ZoneMinder to 1.39.6 and introduces a DB schema change intended to allow non‑English tag names by updating the Tags.Name collation.
Changes:
- Bump version from 1.39.5 to 1.39.6 (core version file + RPM spec).
- Add DB update script
zm_update-1.39.6.sqlto modifyTags.Namecollation. - Update the DB creation schema for
Tags.Nameto use a utf8mb4 collation.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| version.txt | Version bump to 1.39.6. |
| distros/redhat/zoneminder.spec | RPM spec version bump to 1.39.6. |
| db/zm_update-1.39.6.sql | Migration to change Tags.Name collation for multilingual tag names. |
| db/zm_create.sql.in | Updates initial Tags table definition to match the new collation intent. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Oh, so I'm not alone. :) |
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
…the "*_bin" collation instead of "*_unicode_ci" (zm_update-1.39.6.sql).
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The changes to `utf8mb4_unicode_ci` were made deliberately, as I don't think case-sensitivity and accent sensitivity are necessary. Yes, updated installations and new ones will behave differently, but if the user's account is clean, i.e., a new installation, there won't be any conflicts. Well, I don't think using `utf8mb4_unicode_ci` is mandatory for new installations. Let's use `utf8mb4_bin`. Co-authored-by: Copilot Autofix powered by AI <[email protected]>
|
@connortechnology |
No description provided.