CompilerCompat: Include compat modules only when they have version.txt#2033
Merged
ZacSweers merged 1 commit intoZacSweers:mainfrom Mar 23, 2026
Merged
Conversation
kevinguitar
commented
Mar 23, 2026
| add(embedded.name, project(":compiler-compat")) | ||
| rootProject.isolated.projectDirectory.dir("compiler-compat").asFile.listFiles()!!.forEach { | ||
| if (it.isDirectory && it.name.startsWith("k")) { | ||
| if (it.isDirectory && it.name.startsWith("k") && File(it, "version.txt").exists()) { |
Contributor
Author
There was a problem hiding this comment.
Let me know if it's better to check for build.gradle.kts, but I think since it's generated via a script, either way should be alright
Owner
There was a problem hiding this comment.
Works for me ¯_(ツ)_/¯. But there are multiple places that do this so this might not be enough
Contributor
Author
There was a problem hiding this comment.
Ah yeah, I see it now 🙈
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves an error when there are stale compiler targets with
builddirs, currently they will be picked up because of this check. I've enhanced it a bit and check forversion.txtexistence.