Skip to content

Use IZUGFeRDExportableItem.getCalculation instead of LineCalculator constructor#964

Open
WorkProg wants to merge 4 commits intoZUGFeRD:masterfrom
WorkProg:Use-IZUGFeRDExportableItem.getCalculation-instead-of-LineCalculator-constructor
Open

Use IZUGFeRDExportableItem.getCalculation instead of LineCalculator constructor#964
WorkProg wants to merge 4 commits intoZUGFeRD:masterfrom
WorkProg:Use-IZUGFeRDExportableItem.getCalculation-instead-of-LineCalculator-constructor

Conversation

@WorkProg
Copy link
Copy Markdown
Contributor

@WorkProg WorkProg commented Nov 6, 2025

No description provided.

@jstaerk
Copy link
Copy Markdown
Collaborator

jstaerk commented Feb 4, 2026

  1. why? and
  2. can you please fix the conflicts?

thanks!

@WorkProg
Copy link
Copy Markdown
Contributor Author

why? and

IMO doesn't make much sense to have that function and not use it, concretely I was looking into issues with the sums and was confused my changes didn't affect anything because the function is not used.

@WorkProg WorkProg force-pushed the Use-IZUGFeRDExportableItem.getCalculation-instead-of-LineCalculator-constructor branch from 7563398 to 6d6fcf6 Compare March 26, 2026 14:51
@WorkProg
Copy link
Copy Markdown
Contributor Author

@jstaerk to give some more context, we have aggregation at a different place in our system that calculates the row totals and it is more important, that the numbers line up with the values we print on e.g. the PDF than that the value is consistent according to unitPrice * amount = rowTotal.

Ideally we'd want to be able to provide mustang with all values it needs to put on the e-invoice and do the calculations our selves.

@WorkProg
Copy link
Copy Markdown
Contributor Author

@jstaerk, sorry to bother you again. Do you know if this can be merged soon? We are currently blocked by this in our E-Invoicing integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants