octocrab::Error: don't include unconditional backtrace in Display impl#824
Merged
XAMPPRocky merged 1 commit intoXAMPPRocky:mainfrom Apr 27, 2026
Merged
Conversation
Users of this crate cannot currently get an error description without
the backtrace included. This may be undesirable for a number of
reasons, and is inconsistent with the examples in the `snafu`
crate (whose Display implementations generally do not include a
backtrace). Users who want a backtrace to be printed can still do so
for an octocrab Error `e` by writing:
snafu::ErrorCompat::backtrace(&e)
lschuermann
changed the title
octocrab::Error: don't include unconditional backtrace in Display impl
Owner
|
Thank you for your PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users of this crate cannot currently get an error description without the backtrace included. This may be undesirable for a number of reasons, and is inconsistent with the examples in the
snafucrate (whose Display implementations generally do not include a backtrace). Users who want a backtrace to be printed can still do so for an octocrab Erroreby writing:This was requested as part of a pull request to a project using this crate: 0xB10C/github-metadata-backup#11 (comment)