[pull] master from mangostwo:master#183
Merged
pull[bot] merged 11 commits intoWorld0fWarcraft:masterfrom Dec 27, 2025
Merged
Conversation
The Problem: The Auction House Bot is intended to mimic real player auction behavior, which includes selling items commonly farmed and sold by players. However, the AH Bot was designed to not sell any item that an NPC Vendor sells in any quantity. While this makes sense, it prevents items that any Vendor sells in even very limited quantities (such as all sorts of Leather) from every being listed. The Fix: Better mimic desired player auction behavior by allowing the AH Bot to sell limited-quantity vendor items by narrowing the general vendor item restriction to ONLY those items that vendors sell in unlimited quantities. The Details: The AH Bot queries the npc_vendor table to compile a list of items it will Not list on the AH. These query results are narrowed by adding 'WHERE maxcount = 0', which will only capture items that vendors sell in Unlimited quantities, thus allowing Leather to appear on the AH.
* Fixed non PCH build - Updated CMakeLists.txt - Updated GitHub actions - Updated non-portable / not safe localtime* methods - Minor refactoring on some time-to-string methods * Fixed error from GitHub actions * fix trailing space --------- Co-authored-by: Antz <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )