[HL2MP] Only show sparks out of water#1863
Open
blackletum wants to merge 1 commit intoValveSoftware:masterfrom
Open
[HL2MP] Only show sparks out of water#1863blackletum wants to merge 1 commit intoValveSoftware:masterfrom
blackletum wants to merge 1 commit intoValveSoftware:masterfrom
Conversation
Issue: Explosions would show spark underwater. The check was inverted here. Fix: Invert back the check for if the explosion happened underwater. This is simply re-submitting a previous PR that was closed without being merged because the original creator deleted their repo: ValveSoftware#1112
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Explosions would show spark underwater. The check was inverted here.
Fix:
Invert back the check for if the explosion happened underwater.
This is simply re-submitting a previous PR that was closed without being merged because the original creator deleted their repo:
#1112