modifying team.js

[MischiefCS]

This may be intended behaviour, however I believe its an edge case that should be patched against.

Currently it is a simple process for a team to change regions, particularly when they are on the border of an assignment i.e 2 AS 3EU. This can lead to potential benefit, in which the team could easily swap to the Asia rankings to more easily attain the major. There isn't really anyway to prevent this, and it is debatable whether it is an issue or not and the team's core is maintained.

However, the introduction of activeRoster on August 5th has created a disconnect between the internal players that is used for sharesRoster to the publicly displayed roster for invites and region. This creates a manipulable situation in which points can effectively transfer over a non shareRoster boundary.

For example as shown below, a team can transfer the invite slot to 4 different Asias players, slotting into the Asias rankings and maintaining all previous points, as long as the most recent match occupies the shown setup (and is not a forfeit)

This is due to the disconnect between activeRoster and players as mentioned in #35 . This isnt necessarily a significant issue, as its a one and done and is a temporary difference. However it could be done for an invite rankings as key for the major rankings, pushing out true Asias teams from their region.

Given the higher volume of bounties and opponent network in Europe, there are more teams with higher average factors and points and if taking advantage of this would meet the threshold to qualify in another regions rankings.

For example taking a ~50th placed EU team in Tricked and simulating the above condition they would currently be ranked as an Asian team, but have the initiated team assigned to all previous matches as the sharesRoster condition is met. This would then currently place them as 3rd in the Asian Rankings with an activeRoster not overlapping the roster from a majority of matches that are assigning points.

I personally cant think of any way to fix the issue of a core itself not necessarily being authentically represented, however I believe there is a way to prevent a team using this to be inserted into a lower point ceiling region.

This PR additionally collects the region assignment of team.Players and will compare it to the team.region as determined by the team.activeRoster. For this region swap, there must be a regional discrepancy, and there must be a difference of >= 2 players between the initiated team and the activeRoster team for a full 5 EU swap. If those conditions are met and the initiated team region is a higher priority than the activeRoster region it will default to the initiated team region.

In this case the PR would then change it such that the above team condition is assigned to initiated team region, EU

This doesn't currently change any team's regional assignments and shouldn't affect any standard transfers. It should only prevent a team trying to quickly swap to a weaker point ceiling region's rankings which I would assume is unintended behaviour.