Conversation
Make the workflow ticket aware across different repositories (including the GcodeAnalyzer) Moving the script to execute the analyzer to its own repository (to do item) to keep all the connected elements in one place for the analyzer Using the cura.jinja profile for the build to include the overrides - Package override action, checks for existing tag before appending it. Required to be fixed to prevent a duplicated tag error Ultimaker/cura-workflows@038066f - cura.jinja, move the override section to the bottom of the file so we can just append the overrides when required without needing to add the override tag Ultimaker/conan-config@64a4beb
Test Results31 tests ±0 30 ✅ ±0 5s ⏱️ -1s For more details on these failures, see this check. Results for commit 9ec08e4. ± Comparison against base commit 212a4be. |
wawanbreton
left a comment
There was a problem hiding this comment.
Looks good overall, some suggestion and questions
| run: | | ||
| branch="${{ github.head_ref || github.ref_name }}" | ||
| ticket=$(echo "$branch" | grep -oP '^(CURA|PP|NP)-\d+' || echo "") | ||
| echo "ticket=$ticket" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
For more consistency and future-proofness, would it make sense to use the conan-recipe-version action instead ? Since this is the one that generates the conan packages channels, it should always give the proper result even if it iself changes.
This method is simple and much faster though, so this is merely a suggestion.
There was a problem hiding this comment.
I agree, either we would consume the output of the action or run the action (at least that is my ultimate vision). But for now went with the faster option. So follow up ticket once things are working could be a nice addition.
Co-authored-by: Erwan MATHIEU <[email protected]>
Co-authored-by: Erwan MATHIEU <[email protected]>
Make the workflow ticket aware across different repositories (including the GcodeAnalyzer)
Moving the script to execute the analyzer to its own repository (to do item) to keep all the connected elements in one place for the analyzer
Using the cura.jinja profile for the build to include the overrides
CURA-13110