Skip to content

Update the workflow#2326

Open
HellAholic wants to merge 5 commits intomainfrom
CURA-13110_gcodeAnalyzerWorkflow
Open

Update the workflow#2326
HellAholic wants to merge 5 commits intomainfrom
CURA-13110_gcodeAnalyzerWorkflow

Conversation

@HellAholic
Copy link
Copy Markdown
Contributor

@HellAholic HellAholic commented Apr 16, 2026

Make the workflow ticket aware across different repositories (including the GcodeAnalyzer)
Moving the script to execute the analyzer to its own repository (to do item) to keep all the connected elements in one place for the analyzer
Using the cura.jinja profile for the build to include the overrides

  • Package override action, checks for existing tag before appending it. Required to be fixed to prevent a duplicated tag error Ultimaker/cura-workflows@038066f
  • cura.jinja, move the override section to the bottom of the file so we can just append the overrides when required without needing to add the override tag Ultimaker/conan-config@64a4beb

CURA-13110

Make the workflow ticket aware across different repositories (including the GcodeAnalyzer)
Moving the script to execute the analyzer to its own repository (to do item) to keep all the connected elements in one place for the analyzer
Using the cura.jinja profile for the build to include the overrides
- Package override action, checks for existing tag before appending it. Required to be fixed to prevent a duplicated tag error Ultimaker/cura-workflows@038066f
- cura.jinja, move the override section to the bottom of the file so we can just append the overrides when required without needing to add the override tag Ultimaker/conan-config@64a4beb
@HellAholic HellAholic marked this pull request as ready for review April 16, 2026 11:01
@github-actions
Copy link
Copy Markdown
Contributor

Test Results

31 tests  ±0   30 ✅ ±0   5s ⏱️ -1s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 9ec08e4. ± Comparison against base commit 212a4be.

Copy link
Copy Markdown
Contributor

@wawanbreton wawanbreton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, some suggestion and questions

run: |
branch="${{ github.head_ref || github.ref_name }}"
ticket=$(echo "$branch" | grep -oP '^(CURA|PP|NP)-\d+' || echo "")
echo "ticket=$ticket" >> $GITHUB_OUTPUT
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For more consistency and future-proofness, would it make sense to use the conan-recipe-version action instead ? Since this is the one that generates the conan packages channels, it should always give the proper result even if it iself changes.
This method is simple and much faster though, so this is merely a suggestion.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, either we would consume the output of the action or run the action (at least that is my ultimate vision). But for now went with the faster option. So follow up ticket once things are working could be a nice addition.

Comment thread .github/workflows/gcodeanalyzer.yml Outdated
Comment thread .github/workflows/gcodeanalyzer.yml
Comment thread .github/workflows/gcodeanalyzer.yml Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants