[CURA-13024] Spike: merge thin parts of floor/roof/skin#2316
Draft
[CURA-13024] Spike: merge thin parts of floor/roof/skin#2316
Conversation
… vice-versa. Spike/Test/Work in progress/etc. CURA-13024
…e TODOs). part of spike CURA-13024
…onstant. Also take a short-cut if the value is 0. part of spike CURA-13024
Contributor
Test Results31 tests ±0 30 ✅ ±0 4s ⏱️ -1s For more details on these failures, see this check. Results for commit fed0513. ± Comparison against base commit 2783da4. ♻️ This comment has been updated with latest results. |
wawanbreton
requested changes
Apr 1, 2026
Contributor
wawanbreton
left a comment
wawanbreton
left a comment
There was a problem hiding this comment.
The global implementation is very elegant and should indeed work without edge-cases. I have a few suggestions/requests though, to be challenged of course 🙂
Most notably, rewrite mergeThinOverlap a bit to do a mostly inplace alteration of the polygons, have some extra early-out(s) and move the method to where we can re-use it later should the need arise. part of spike CURA-13024
wawanbreton
approved these changes
Apr 1, 2026
Contributor
wawanbreton
left a comment
wawanbreton
left a comment
There was a problem hiding this comment.
Just one more possible optimization, otherwise looks good !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge roof/floor into skin or vice-versa, given a distance, where anything under this is considered 'too thin' and will be merged to the other areas when next to each other.
See frontend PR for the accompanying setting: Ultimaker/Cura#21515