feat: add project-wide i18n support#209
Draft
NAO-200 wants to merge 37 commits into
Draft
Conversation
Collaborator
|
There were a lot of files changed, very hard to look at everything, but in general looks fine from my point of view. Don't forget to add docstrings and specify which files you said were incorrectly merged |
| }, | ||
|
|
||
| async down(queryInterface, Sequelize) { | ||
| // Intentionally left as no-op because original free-text values were not uniquely preserved. |
Collaborator
There was a problem hiding this comment.
Is there any way that we can avoid breaking undoing of migrations? Once we run these migrations we cannot go back to a previous version of the app.
| }, | ||
|
|
||
| async down(queryInterface, Sequelize) { | ||
| // No-op: reverse mapping is intentionally omitted. |
Collaborator
There was a problem hiding this comment.
Same as mentioned before
| }, | ||
|
|
||
| async down(queryInterface, Sequelize) { | ||
| // No-op: reverse mapping intentionally omitted. |
Collaborator
Author
The commit where I adapted the first ~100 files and where old logic was accidentally merged is:
This was the part where I initially tried to port changes that looked safe, but later noticed that some old logic had been brought back unintentionally. Because of that, I manually re-checked these files afterwards against the current (caution, a lot of files) Full list of files included in this commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #155
Adapts the project to the existing i18n setup across the frontend, including dashboard views, modals, navigation, model-driven forms, validation messages, and backend-provided messages.