Skip to content

Remove all ReSharper suppression comments#326

Merged
Tyrrrz merged 2 commits intoprimefrom
copilot/remove-all-resharper-comments
Apr 14, 2026
Merged

Remove all ReSharper suppression comments#326
Tyrrrz merged 2 commits intoprimefrom
copilot/remove-all-resharper-comments

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 14, 2026

Removes all // ReSharper disable once ... inline suppression comments from the codebase. These are IDE-specific noise that don't belong in source.

Files changed

  • CliWrap/Command.Execution.cs — removed 4 suppression hints (AccessToDisposedClosure, PossiblyMistakenUseOfCancellationToken)
  • CliWrap/PipeTarget.cs — removed 2 × AccessToDisposedClosure
  • CliWrap/EventStream/PullEventStreamCommandExtensions.cs — removed 3 × AccessToDisposedClosure
  • CliWrap/Utils/Extensions/AsyncDisposableExtensions.cs — removed SuspiciousTypeConversion.Global
  • CliWrap.Tests/PipingSpecs.cs — removed AccessToDisposedClosure ×2, FunctionNeverReturns

Agent-Logs-Url: https://github.com/Tyrrrz/CliWrap/sessions/e306415c-5eb6-45f8-b1b3-44cc26679763

Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>
@Tyrrrz Tyrrrz marked this pull request as ready for review April 14, 2026 19:12
Copilot AI review requested due to automatic review settings April 14, 2026 19:12
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.51%. Comparing base (a2ab9e8) to head (b911ba2).
⚠️ Report is 1 commits behind head on prime.

Additional details and impacted files
@@            Coverage Diff             @@
##            prime     #326      +/-   ##
==========================================
- Coverage   94.57%   94.51%   -0.06%     
==========================================
  Files          34       34              
  Lines        1124     1112      -12     
  Branches       72       72              
==========================================
- Hits         1063     1051      -12     
  Misses         40       40              
  Partials       21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes IDE-specific ReSharper inline suppression comments from CliWrap source and tests to reduce source noise while keeping the code behavior unchanged.

Changes:

  • Removed // ReSharper disable once ... suppressions across core piping/execution code paths.
  • Removed the remaining suppression in async-disposable adapter utilities.
  • Removed suppressions from piping-related tests.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
CliWrap/Command.Execution.cs Removes ReSharper suppressions around cancellation token usage and callback closure capture.
CliWrap/PipeTarget.cs Removes ReSharper suppressions in aggregate piping error/abort flow.
CliWrap/EventStream/PullEventStreamCommandExtensions.cs Removes ReSharper suppressions in event publishing and completion continuation.
CliWrap/Utils/Extensions/AsyncDisposableExtensions.cs Removes ReSharper suppression in async-disposable adapter type check.
CliWrap.Tests/PipingSpecs.cs Removes ReSharper suppressions in piping tests and an intentionally non-terminating pipe source.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Tyrrrz
Copy link
Copy Markdown
Owner

Tyrrrz commented Apr 14, 2026

@copilot please fix formatting issues by running the build

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 14, 2026

@copilot please fix formatting issues by running the build

Fixed in b911ba2. CSharpier reformatted two files: collapsed a single-expression lambda in PipingSpecs.cs, collapsed a single-statement lambda in Command.Execution.cs, and removed a trailing blank line in PipingSpecs.cs.

Copilot AI requested a review from Tyrrrz April 14, 2026 19:19
@Tyrrrz Tyrrrz merged commit 4b0fec1 into prime Apr 14, 2026
7 checks passed
@Tyrrrz Tyrrrz deleted the copilot/remove-all-resharper-comments branch April 14, 2026 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants