Remove all ReSharper suppression comments#326
Merged
Conversation
Agent-Logs-Url: https://github.com/Tyrrrz/CliWrap/sessions/e306415c-5eb6-45f8-b1b3-44cc26679763 Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
Tyrrrz
April 14, 2026 19:12
View session
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## prime #326 +/- ##
==========================================
- Coverage 94.57% 94.51% -0.06%
==========================================
Files 34 34
Lines 1124 1112 -12
Branches 72 72
==========================================
- Hits 1063 1051 -12
Misses 40 40
Partials 21 21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes IDE-specific ReSharper inline suppression comments from CliWrap source and tests to reduce source noise while keeping the code behavior unchanged.
Changes:
- Removed
// ReSharper disable once ...suppressions across core piping/execution code paths. - Removed the remaining suppression in async-disposable adapter utilities.
- Removed suppressions from piping-related tests.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| CliWrap/Command.Execution.cs | Removes ReSharper suppressions around cancellation token usage and callback closure capture. |
| CliWrap/PipeTarget.cs | Removes ReSharper suppressions in aggregate piping error/abort flow. |
| CliWrap/EventStream/PullEventStreamCommandExtensions.cs | Removes ReSharper suppressions in event publishing and completion continuation. |
| CliWrap/Utils/Extensions/AsyncDisposableExtensions.cs | Removes ReSharper suppression in async-disposable adapter type check. |
| CliWrap.Tests/PipingSpecs.cs | Removes ReSharper suppressions in piping tests and an intentionally non-terminating pipe source. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
@copilot please fix formatting issues by running the build |
Agent-Logs-Url: https://github.com/Tyrrrz/CliWrap/sessions/9171204a-1f8d-4b32-a26b-21744486f5ec Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes all
// ReSharper disable once ...inline suppression comments from the codebase. These are IDE-specific noise that don't belong in source.Files changed
CliWrap/Command.Execution.cs— removed 4 suppression hints (AccessToDisposedClosure,PossiblyMistakenUseOfCancellationToken)CliWrap/PipeTarget.cs— removed 2 ×AccessToDisposedClosureCliWrap/EventStream/PullEventStreamCommandExtensions.cs— removed 3 ×AccessToDisposedClosureCliWrap/Utils/Extensions/AsyncDisposableExtensions.cs— removedSuspiciousTypeConversion.GlobalCliWrap.Tests/PipingSpecs.cs— removedAccessToDisposedClosure×2,FunctionNeverReturns