Skip to content

Make tryghost/activitypub-migrations Dockerfile multiplatform#1833

Open
touzoku wants to merge 1 commit into
TryGhost:mainfrom
touzoku:patch-1
Open

Make tryghost/activitypub-migrations Dockerfile multiplatform#1833
touzoku wants to merge 1 commit into
TryGhost:mainfrom
touzoku:patch-1

Conversation

@touzoku
Copy link
Copy Markdown

@touzoku touzoku commented May 26, 2026

  • Pin sha256 of the image index, not the platform manifest digest. Use fully qualified container name.
  • Use TARGETARCH to download the correct golang migrate binary

- Pin sha256 of the image index, not the platform manifest digest. Use fully qualified container name.
- Use TARGETARCH to download the correct golang migrate binary
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 26, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5aacf585-e407-47d7-ba7b-f8ca9b7e831b

📥 Commits

Reviewing files that changed from the base of the PR and between 4a14d50 and ff78ab0.

📒 Files selected for processing (1)
  • migrate/Dockerfile

Walkthrough

The migrate/Dockerfile is updated to enable multi-architecture Docker builds. The base Debian image reference is changed to the fully qualified docker.io/library/debian path (retaining the same digest). The migrate binary download URL is parameterized using the TARGETARCH build argument, switching from a hard-coded migrate.linux-amd64 artifact to migrate.linux-${TARGETARCH}, allowing the same Dockerfile to build for different CPU architectures. The remaining instructions (installing curl, copying bin and migrations directories, setting MYSQL_DB environment variable, and default CMD) remain unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: making the Dockerfile multiplatform-compatible, which is the primary objective of this PR.
Description check ✅ Passed The description directly relates to the changeset, explaining the two key modifications: pinning the image sha256 with fully qualified container name and using TARGETARCH for the golang-migrate binary.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant