🛡️ Sentinel: [HIGH] Fix JS Injection in DOM querying#39
🛡️ Sentinel: [HIGH] Fix JS Injection in DOM querying#39ToufiqQureshi wants to merge 1 commit intomainfrom
Conversation
- Use json.dumps() to safely escape CSS selectors in JS templates. - Explicitly cast idx to int to prevent injection via node_data. - Addresses potential arbitrary JS execution via crafted selectors. Co-authored-by: ToufiqQureshi <[email protected]>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 participant
🚨 Severity: HIGH
💡 Vulnerability: JS Injection via f-string interpolation of CSS selectors into JavaScript backticks.
🎯 Impact: An attacker or a malicious script providing a crafted CSS selector could execute arbitrary JavaScript in the browser context.
🔧 Fix: Used
json.dumps()to safely escape selectors andint()to harden numeric indices in JS templates.✅ Verification: Verified via manual code inspection and logic simulation script confirming that backticks are escaped and the selector is treated as a string literal.
PR created automatically by Jules for task 14937487667443390530 started by @ToufiqQureshi