Incorrect status is shown when ETA end date has already passed#1
Open
TuxToaster wants to merge 1 commit intoTheSeg:mainfrom
Open
Incorrect status is shown when ETA end date has already passed#1TuxToaster wants to merge 1 commit intoTheSeg:mainfrom
TuxToaster wants to merge 1 commit intoTheSeg:mainfrom
Conversation
Nerwyn
approved these changes
Nov 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to
getDaysToDeliveryusingMath.abswhen calculating the time difference, the status shows an incorrectly increasing value if the delivery has gone beyond the ETA end date (e.g. for a delivery that should have happened two days ago on September 13th, it currently shows "is estimated to be delivered to dealer in 2 days."This change removes the call to
Math.abs, and the resulting status for the above now simply shows as "In Transit".