Skip to content

Drop Octoshock#4180

Open
YoshiRulz wants to merge 3 commits into
masterfrom
drop-octoshock
Open

Drop Octoshock#4180
YoshiRulz wants to merge 3 commits into
masterfrom
drop-octoshock

Conversation

@YoshiRulz
Copy link
Copy Markdown
Member

@YoshiRulz YoshiRulz commented Jan 10, 2025

Needed to keep some managed code around since the .pjm importer uses the sync settings type for serialisation.

Definitely update Input_Display.lua to the Nymashock names after this (see #3468).

See #3273.

@Spikestuff
Copy link
Copy Markdown
Contributor

Spikestuff commented Jan 10, 2025

This should probably force the priority in getting the debugger to work in Nymashock to be more important then, right?
Otherwise referring to "please use Octoshock in 2.10" would kinda suck years down the line (and versions) if it's not complete.

Edit: Nevermind saw the mention of it in #3273 which is being ref'd here~

@CasualPokePlayer
Copy link
Copy Markdown
Member

CasualPokePlayer commented Jan 10, 2025

"Debugger to work in Nymashock" isn't really the point of the "standard debugging features." It's more for Lua stuff and the tracelogger, which are infinitely more useful than that crap debugger.

@vadosnaprimer
Copy link
Copy Markdown
Contributor

I forgot, isn't nymashock based on mednafen's clean untouched source code? Adding debugging to it would involve changing it on our side.

@CasualPokePlayer
Copy link
Copy Markdown
Member

  1. The source code is not untouched, it's just (intended to be, at least) minimally modified. Just having lag stuff requires some touching of the code, arguably just as much as mem hooks would be.
  2. mednafen has some debugging code in it already, it might be possible to rather just wire that up if anything (although again, if not, the debugging hooks are minimal regardless)

@YoshiRulz
Copy link
Copy Markdown
Member Author

This should probably force the priority in getting the debugger to work in Nymashock to be more important then, right? Otherwise referring to "please use Octoshock in 2.10" would kinda suck years down the line (and versions) if it's not complete.

My opinion is that this shouldn't be blocked by Nymashock missing features. We just released our least buggy version yet, so if a few power users need to hold on it for a couple releases, that wouldn't be so bad. And perhaps regressing on those features would motivate working on Nymashock? I don't actually know who's maintaining it atm...

And the same goes for BSNES, though it's much easier there since DiztinGUIsh makes up for our lack of CDL.

@YoshiRulz YoshiRulz added this to the 2.10.2 milestone Apr 8, 2025
@YoshiRulz YoshiRulz added the Core: Octoshock Playstation (PSX/PS1) core label Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Core: Octoshock Playstation (PSX/PS1) core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants