Enabled as open web service in Open Source Cloud#2
Open
birme wants to merge 8 commits intoSuperFlyTV:mainfrom
Open
Enabled as open web service in Open Source Cloud#2birme wants to merge 8 commits intoSuperFlyTV:mainfrom
birme wants to merge 8 commits intoSuperFlyTV:mainfrom
Conversation
… Source Cloud information 🤖 Generated with OSaaS Service Builder
- Add Dockerfile.osc with multi-stage Node.js/Yarn 4 build - Add osc-entrypoint.sh with S3/MinIO sync for graphics storage - Fix server.ts: read PORT from env var instead of hardcoding 8080 - Fix server.ts: inject OSC_HOSTNAME as __OGRAF_SERVER_URL__ into controller index.html so the Simple Controller auto-connects to the correct public API URL (fixes 401/Failed to fetch issues) - Fix appSettings.ts: prefer injected URL over stored localhost URL - Fix GraphicsStore.ts: use GRAPHICS_STORAGE_PATH env var (defaults to /data/localGraphicsStorage for persistent volume) S3_GRAPHICS_URL + S3_ENDPOINT_URL enable MinIO bucket integration for graphics storage, matching the pattern used in the SPX fork.
When running behind OSC's HTTPS ingress, the renderer's hardcoded
ws://localhost:8080 WebSocket URL fails. Add a route handler for /renderer/*
that injects window.__OGRAF_WS_URL__ into the renderer's index.html,
using wss://{OSC_HOSTNAME} when OSC_HOSTNAME is set and falling back to
ws://localhost:{PORT} for local development.
Mirrors the pattern already applied to the controller in commit 2825b2e.
Co-Authored-By: Claude <[email protected]>
Replace hardcoded ws://localhost:8080 with window.__OGRAF_WS_URL__ (injected by the server into the renderer index.html when OSC_HOSTNAME is set). Falls back to deriving the URL from window.location: wss:// when the page is served over HTTPS, ws:// otherwise. This ensures the renderer works correctly when running on OSC behind HTTPS ingress. Co-Authored-By: Claude <[email protected]>
The renderer's serverApiUrl was hardcoded to http://localhost:8080 which fails when deployed on any non-localhost environment. The server now reads a PUBLIC_URL environment variable and injects the correct URL into both the renderer and controller HTML at serve time, falling back to localhost when PUBLIC_URL is not set. Changes: - App.tsx: use injected __OGRAF_SERVER_URL__ or window.location.origin instead of hardcoded localhost - server.ts: derive all client-facing URLs from PUBLIC_URL env var, removing direct OSC_HOSTNAME references - index.html: replace hardcoded localhost URLs with relative paths - osc-entrypoint.sh: map OSC_HOSTNAME to PUBLIC_URL Closes Eyevinn/agent-team-supply#134 Co-authored-by: Claude Opus 4.6 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
With this Pull Request we want to give you the option to add a badge to your README to show that
your software is available as an open web service in Eyevinn Open Source Cloud.
With Eyevinn Open Source Cloud we turn open source into open web services and share the revenue
with the creators.
Our goal with this platform is to reduce the barrier to get started with open source and contribute
to a sustainable business for open source by giving back a share of the revenue to the creators.
For our customers we can offer full code transparency and no vendor lock-in as all web services
are open source.
We want to not be evil and we do this to provide the creators with an additional
income stream for their projects.
Our pledge to the community is to:
as a public fork.
and never lock in to our platform or the underlying infrastructure.
To claim ownership and receive a revenue share follow the instructions in
the documentation for creators.
Jonas Birme
CTO Eyevinn Open Source Cloud