Fix bug where subtitles are sometimes rendered tiny#27
Open
DoomTay wants to merge 5 commits intoSunnyLi:masterfrom
Open
Fix bug where subtitles are sometimes rendered tiny#27DoomTay wants to merge 5 commits intoSunnyLi:masterfrom
DoomTay wants to merge 5 commits intoSunnyLi:masterfrom
Conversation
Contributor
Author
|
Hmm...after some further testing, it seems the issue has NOT been fixed completely |
Contributor
Author
|
There. That should fix it for real. |
For some reason, this still sometimes caused the tiny text bug. No more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a "ready" event listener to the first renderer made and moves setting up "play" to that listener callback. Otherwise, #26 happens.