feat: add optional max swap tax amount hook input#19
Merged
crypto-banker merged 4 commits intomainfrom Mar 25, 2026
Merged
Conversation
Takes advantage of the previously-unused `hookData` param input to the `beforeSwap()` hook, which is named `optionalMaxSwapTax` for clarity. *If* non-empty `optionalMaxSwapTax` is supplied, then it is decoded as a uint and compared to the calculated swap tax amount; reversion with a `SwapTaxExceedsSpecifiedMax` error will occur if the swap tax amount exceeds the specified value
xenide
reviewed
Mar 25, 2026
xenide
approved these changes
Mar 25, 2026
Contributor
xenide
left a comment
xenide
left a comment
There was a problem hiding this comment.
looks good. Once we have the base case test case I think we can merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes advantage of the previously-unused
hookDataparam input to thebeforeSwap()hook, which is namedoptionalMaxSwapTaxfor clarity.If non-empty
optionalMaxSwapTaxis supplied, then it is decoded as a uint and compared to the calculated swap tax amount; reversion with aSwapTaxExceedsSpecifiedMaxerror will occur if the swap tax amount exceeds the specified value.If an empty
optionalMaxSwapTaxis supplied then there is no change from the prior behavior -- no attempt is made at decoding and the swap proceeds as normal.