[WIP] [RuleEngine] Attribute Locator interface#3836
Open
vahonc wants to merge 4 commits intoSmile-SA:2.10.xfrom
Open
[WIP] [RuleEngine] Attribute Locator interface#3836vahonc wants to merge 4 commits intoSmile-SA:2.10.xfrom
vahonc wants to merge 4 commits intoSmile-SA:2.10.xfrom
Conversation
…on provider and tests
rbayet
requested changes
Apr 24, 2026
| /** | ||
| * Optimizer table name. | ||
| */ | ||
| private const TABLE_NAME = 'smile_elasticsuite_optimizer'; |
Collaborator
There was a problem hiding this comment.
Please rely instead on \Smile\ElasticsuiteCatalogOptimizer\Api\Data\OptimizerInterface::TABLE_NAME
| /** | ||
| * Attribute code storing virtual category rules. | ||
| */ | ||
| private const ATTRIBUTE_CODE = 'virtual_rule'; |
Collaborator
There was a problem hiding this comment.
Please provide the attribute_code in the constructor so it could be altered through DI if needed in the future
| /** | ||
| * Entity type code for categories. | ||
| */ | ||
| private const ENTITY_TYPE = 'catalog_category'; |
Collaborator
There was a problem hiding this comment.
Please rely instead on \Magento\Catalog\Api\Data\CategoryAttributeInterface::ENTITY_TYPE_CODE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.