ci: gate Deploy changesets job to push events only (2026-07-rc)#4472
ci: gate Deploy changesets job to push events only (2026-07-rc)#4472andy-chhuon wants to merge 2 commits into
Conversation
🚨🚨🚨 Docs migration in progress 🚨🚨🚨We are actively migrating UI extension reference docs to MDX in the
During this migration, please be aware of the following:
Doc comments in Examples that previously lived in this repo are being moved to the What should I do?
Thanks for your patience while we complete the migration! 🙏 |
Summary
Backport of #4471 to
2026-07-rc.The
changesetsjob in.github/workflows/deploy.ymlis missing an event-type guard. The workflow runs on bothpush(release branches) andissue_comment.created(for/snapit). Thesnapitjob correctly guards itself withevent_name == 'issue_comment', butchangesetshas noif:and would fire on everyissue_comment.createdevent from any GitHub user if the trigger were ever active on the default branch.Today this is non-exploitable on this branch because
issue_commentevents route through the default branch (unstable), whosedeploy.ymldoes not carry the trigger. The fix here is structural defense-in-depth so the misconfig does not propagate forward when the workflow is updated.Fix
Symmetric one-line guard mirroring the
snapitjob's pattern:After this change,
issue_comment.createdevents fire only thesnapitjob;pushevents to release branches fire only thechangesetsjob. Reported via bug bounty (parent PR: #4471).