docs: remove references to non-existing methods#2072
Open
markokajzer wants to merge 2 commits intoShopify:mainfrom
Open
docs: remove references to non-existing methods#2072markokajzer wants to merge 2 commits intoShopify:mainfrom
markokajzer wants to merge 2 commits intoShopify:mainfrom
Conversation
naqvitalha
force-pushed
the
main
branch
4 times, most recently
from
ada29af to
660b77d
Compare
Collaborator
|
Can you sign the CLA? |
Author
|
I have signed the CLA! |
naqvitalha
approved these changes
Mar 3, 2026
naqvitalha
approved these changes
Mar 11, 2026
Collaborator
naqvitalha
left a comment
naqvitalha
left a comment
There was a problem hiding this comment.
LGTM — the rename is correct; getVisibleIndices doesn't exist, computeVisibleIndices does. Minor note: the docs in usage.md still describe the return type as number[] but the actual signature returns { startIndex: number; endIndex: number }. Pre-existing issue, not a blocker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I noticed the docs are referencing a method that does not exist
getVisibleIndices.I am guessing the method referred to is
computeVisibleIndices. Best example is the example forcomputeVisibleIndicesitself.