Skip to content

Move Swift dev commands under root dev.yml#36

Merged
kyle-schellen merged 1 commit into
mainfrom
05-08-move_swift_dev_commands_under_root_dev.yml
May 13, 2026
Merged

Move Swift dev commands under root dev.yml#36
kyle-schellen merged 1 commit into
mainfrom
05-08-move_swift_dev_commands_under_root_dev.yml

Conversation

@kyle-schellen
Copy link
Copy Markdown
Contributor

@kyle-schellen kyle-schellen commented May 8, 2026

What changes are you making?

Move swift/dev.yml into namespaced commands at the repo root sodev up and dev swift <cmd> work from the monorepo root. Refs issue #908. React Native to follow upstack.

How to test

From the repo root:

  • dev up completes without error, including Mint bootstrap, Xcode 26.2, Storefront.xcconfig, and entitlements setup
  • dev swift lint runs platforms/swift/Scripts/lint
  • dev swift style still works as a legacy alias for lint
  • dev swift format runs platforms/swift/Scripts/lint fix
  • dev swift fix still works as a legacy alias for format
  • dev swift build builds the Swift package target
  • dev swift build packages builds the Swift package target
  • dev swift build samples builds the sample apps
  • dev swift test runs the full ShopifyCheckoutKit-Package test suite
  • dev swift test <ClassName> scopes the test run to one test class
  • dev swift clean cleans Swift package build artifacts
  • dev swift check license-headers checks Swift license headers

Before you merge

Important

  • I've added tests to support my implementation
  • I have read and agree with the Contribution Guidelines
  • I have read and agree with the Code of Conduct
  • I've updated the relevant platform README (swift/README.md and/or android/README.md)

Releasing a new Swift version?
  • I have bumped the version in swift/ShopifyCheckoutKit.podspec
  • I have bumped the version in swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swift
  • I have updated swift/CHANGELOG.md
  • I have updated the SwiftPM/CocoaPods version snippets in swift/README.md (major version only)
Releasing a new Android version?
  • I have bumped the versionName in android/lib/build.gradle
  • I have updated android/CHANGELOG.md
  • I have updated the Gradle/Maven version snippets in android/README.md

Tip

See the Contributing documentation for the full release process per platform.

@kyle-schellen kyle-schellen self-assigned this May 8, 2026
@kyle-schellen kyle-schellen force-pushed the 05-08-move_android_dev_commands_under_root_dev.yml branch from e2fdea2 to dbc5438 Compare May 10, 2026 16:15
@kyle-schellen kyle-schellen force-pushed the 05-08-move_swift_dev_commands_under_root_dev.yml branch 2 times, most recently from f81f5e1 to 2f444c7 Compare May 10, 2026 16:30
@kyle-schellen kyle-schellen force-pushed the 05-08-move_android_dev_commands_under_root_dev.yml branch from dbc5438 to 6e8f971 Compare May 10, 2026 16:38
@kyle-schellen kyle-schellen force-pushed the 05-08-move_swift_dev_commands_under_root_dev.yml branch 2 times, most recently from 0c8370e to 11b5dd9 Compare May 10, 2026 16:53
@markmur markmur added the #gsd:50662 Rebase Checkout Kit on UCP label May 11, 2026
@kyle-schellen kyle-schellen force-pushed the 05-08-move_swift_dev_commands_under_root_dev.yml branch 2 times, most recently from 11b5dd9 to 93232df Compare May 11, 2026 14:31
@kyle-schellen kyle-schellen marked this pull request as ready for review May 11, 2026 14:58
@kyle-schellen kyle-schellen requested a review from a team May 11, 2026 14:59
@kyle-schellen kyle-schellen force-pushed the 05-08-move_android_dev_commands_under_root_dev.yml branch from f73c836 to 7d3dd73 Compare May 11, 2026 20:25
@kyle-schellen kyle-schellen force-pushed the 05-08-move_swift_dev_commands_under_root_dev.yml branch from 93232df to 412dab9 Compare May 11, 2026 20:25
Comment thread dev.yml Outdated
@kyle-schellen kyle-schellen force-pushed the 05-08-move_android_dev_commands_under_root_dev.yml branch from 7d3dd73 to 68173bf Compare May 12, 2026 13:58
@kyle-schellen kyle-schellen force-pushed the 05-08-move_swift_dev_commands_under_root_dev.yml branch 2 times, most recently from 94fc5d5 to 31fba85 Compare May 12, 2026 14:04
@kyle-schellen kyle-schellen force-pushed the 05-08-move_android_dev_commands_under_root_dev.yml branch from 68173bf to e0453ab Compare May 12, 2026 16:37
@kyle-schellen kyle-schellen requested a review from a team as a code owner May 12, 2026 16:37
@kyle-schellen kyle-schellen force-pushed the 05-08-move_swift_dev_commands_under_root_dev.yml branch from 31fba85 to 92ff28b Compare May 12, 2026 16:37
@kyle-schellen kyle-schellen force-pushed the 05-08-move_android_dev_commands_under_root_dev.yml branch from e0453ab to ee59056 Compare May 12, 2026 17:41
@kyle-schellen kyle-schellen force-pushed the 05-08-move_swift_dev_commands_under_root_dev.yml branch 2 times, most recently from 8d11dc5 to d26f92e Compare May 12, 2026 18:22
@kyle-schellen kyle-schellen force-pushed the 05-08-move_android_dev_commands_under_root_dev.yml branch from ee59056 to 84d8099 Compare May 12, 2026 21:37
@kyle-schellen kyle-schellen force-pushed the 05-08-move_swift_dev_commands_under_root_dev.yml branch from d26f92e to 3b360d1 Compare May 12, 2026 21:37
Base automatically changed from 05-08-move_android_dev_commands_under_root_dev.yml to main May 13, 2026 14:51
@kyle-schellen kyle-schellen force-pushed the 05-08-move_swift_dev_commands_under_root_dev.yml branch from 3b360d1 to cf9fc4b Compare May 13, 2026 14:54
Copy link
Copy Markdown
Contributor Author

kyle-schellen commented May 13, 2026

Merge activity

  • May 13, 3:21 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • May 13, 3:21 PM UTC: @kyle-schellen merged this pull request with Graphite.

@kyle-schellen kyle-schellen merged commit f18af35 into main May 13, 2026
46 of 50 checks passed
@kyle-schellen kyle-schellen deleted the 05-08-move_swift_dev_commands_under_root_dev.yml branch May 13, 2026 15:21
kyle-schellen added a commit that referenced this pull request May 13, 2026
Refs issue #[908](shop/issues-checkout-kit#908).

### What changes are you making?

Move `platforms/react-native/dev.yml` into namespaced commands at the repo
root so `dev up` and `dev react-native <cmd>` (or `dev rn`) work from the
monorepo root. Last in the stack after #35 (Android) and #36 (Swift).

Also addresses review feedback to align RN with the Swift/Android shape:

- Adds `s` alias for `server`
- Drops the misleading `check` alias on `lint` (Android `check` has a larger surface; RN had no license-header check to back it)
- Renames `fix` → `format` with `fix` kept as a legacy alias (matches the `dev <platform> format` convention)
- Adds `dev rn build` so all three platforms expose a `build` subcommand
- Updates `scripts/lint_swift` help text to point at the canonical `dev react-native format`

## How to test

From the repo root:

- `dev up` completes without error, including Node v22.14.0 / pnpm 10.33.1 setup, RN dependencies, gems, and pods
- `dev rn build` builds the `@shopify/checkout-kit-react-native` module
- `dev rn lint` runs SwiftLint/SwiftFormat checks, module lint, and sample lint
- `dev rn style` still works as a legacy alias for `lint`
- `dev rn lint swift`, `dev rn lint module`, and `dev rn lint sample` scope linting to one area
- `dev rn format` auto-fixes Swift lint and format issues (SwiftLint + SwiftFormat)
- `dev rn fix` still works as a legacy alias for `format`
- `dev rn server` starts Metro
- `dev rn s` still works as a short alias for `server`
- `dev rn ios` runs the iOS sample app
- `dev rn android` runs the Android sample app
- `dev rn clean` wipes module + sample workspaces and stops `sccache`

---

### Before you merge

> [!IMPORTANT]
>
> - [ ] I've added tests to support my implementation
> - [ ] I have read and agree with the [Contribution Guidelines](./CONTRIBUTING.md)
> - [ ] I have read and agree with the [Code of Conduct](./CODE_OF_CONDUCT.md)
> - [ ] I've updated the relevant platform README (`platforms/swift/README.md` and/or `platforms/android/README.md`)

---

<details>
<summary>Releasing a new Swift version?</summary>

- [ ] I have bumped the version in `platforms/swift/ShopifyCheckoutKit.podspec`
- [ ] I have bumped the version in `platforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swift`
- [ ] I have updated `platforms/swift/CHANGELOG.md`
- [ ] I have updated the SwiftPM/CocoaPods version snippets in `platforms/swift/README.md` (major version only)

</details>

<details>
<summary>Releasing a new Android version?</summary>

- [ ] I have bumped the `versionName` in `platforms/android/lib/build.gradle`
- [ ] I have updated `platforms/android/CHANGELOG.md`
- [ ] I have updated the Gradle/Maven version snippets in `platforms/android/README.md`

</details>

> [!TIP]
> See the [Contributing documentation](./CONTRIBUTING.md) for the full release process per platform.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

#gsd:50662 Rebase Checkout Kit on UCP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants