Merged
Conversation
added 2 commits
October 7, 2025 00:12
Rewrites Installation part of README.md Restructures Dockerfile Adds docker push github workflow
Septimus4
reviewed
Oct 9, 2025
Septimus4
requested changes
Oct 16, 2025
.github/workflows/docker-publish.yml
Outdated
Comment on lines
+3
to
+6
| on: | ||
| push: | ||
| branches: ["main"] # Change to your default branch | ||
| tags: ["v*"] # Trigger on version tags (e.g., v1.0.0) |
Owner
There was a problem hiding this comment.
Can you update to only publish on tags, remove push to main.
.github/workflows/docker-publish.yml
Outdated
|
|
||
| env: | ||
| REGISTRY: ghcr.io | ||
| IMAGE_NAME: ${{ github.repository }} |
Owner
There was a problem hiding this comment.
GHCR requires lowercase names ${{ toLower(github.repository) }}
README.md
Outdated
Comment on lines
+46
to
+52
| docker pull ghcr.io/Septimus4/Chronogen | ||
| ``` | ||
|
|
||
| then use it: | ||
|
|
||
| ```bash | ||
| docker run ghcr.io/Septimus4/Chronogen [ARGS] |
Owner
There was a problem hiding this comment.
Needs lowercase and a tag (either :latest or :${VERSION}), for the readme let's go with latest
Comment on lines
+36
to
+43
| - name: Build and push Docker image | ||
| uses: docker/build-push-action@v5 | ||
| with: | ||
| context: . | ||
| push: true | ||
| tags: | | ||
| ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:latest | ||
| ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:${{ steps.version.outputs.version }} |
Owner
There was a problem hiding this comment.
can you add OCI labels
and add caching to speed up next builds
with:
cache-from: type=gha
cache-to: type=gha,mode=max
Updates docker workflow to handle lowercase naming and OCI labels Updates README.md to lowercase docker label and adds tag
Septimus4
approved these changes
Oct 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.