feat: add timestamp support to subgraph announcements#102
Open
marcomariscal wants to merge 2 commits intomainfrom
Open
feat: add timestamp support to subgraph announcements#102marcomariscal wants to merge 2 commits intomainfrom
marcomariscal wants to merge 2 commits intomainfrom
Conversation
Resolves #88 by adding timestamp field support to subgraph announcements. Changes: - Add required timestamp field to SubgraphAnnouncementEntity type - Update GraphQL query to request timestamp from subgraph - Extend AnnouncementLog interface with optional timestamp field - Update conversion function to handle timestamp with proper BigInt conversion - Add comprehensive tests for timestamp handling - Use Number.parseInt() for safer numeric conversions Architecture: - SubgraphAnnouncementEntity.timestamp is required (subgraphs provide it) - AnnouncementLog.timestamp is optional (supports both subgraph and direct logs) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
marcomariscal
temporarily deployed
to
Testing All Networks
GitHub Actions
Inactive
marcomariscal
temporarily deployed
to
Testing All Networks
GitHub Actions
Inactive
- Remove extra blank line in test file 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
marcomariscal
temporarily deployed
to
Testing All Networks
GitHub Actions
Inactive
marcomariscal
temporarily deployed
to
Testing All Networks
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #88 by adding timestamp field support to subgraph announcements.
Changes
timestampfield toSubgraphAnnouncementEntitytypetimestampfrom subgraphAnnouncementLoginterface with optionaltimestampfieldNumber.parseInt()for safer numeric conversionsArchitecture Decision
SubgraphAnnouncementEntity.timestampis required since subgraphs always provide itAnnouncementLog.timestampis optional to support both data sources:Test Results
🤖 Generated with Claude Code