Improve explicit imports hygiene#53
Merged
ChrisRackauckas merged 1 commit intoJan 8, 2026
Merged
Conversation
- Made all imports explicit using ExplicitImports.jl - Added explicit imports for DiffEqBase, SciMLBase, GeometricIntegrators - Added ExplicitImports.jl tests to prevent regression - Fixed test file imports to work with explicit imports All imports are now explicit, reducing risk of issues from transitive dependencies. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves explicit imports hygiene for the
GeometricIntegratorsDiffEq.jlpackage usingExplicitImports.jl.Changes made:
Made all imports explicit in
src/GeometricIntegratorsDiffEq.jl:Reexportand@reexportfromReexport.jlDiffEqBaseimport explicit in the@reexportstatementSciMLBase:ReturnCode,check_keywords,isinplace,warn_compatGeometricIntegrators:CrankNicolson,Crouzeix,ExplicitEuler,ExplicitMidpoint,Gauss,Heun2,Heun3,ImplicitEuler,ImplicitMidpoint,KraaijevangerSpijker,Kutta3,LobattoIIIA,LobattoIIIAIIIB,LobattoIIIB,LobattoIIIBIIIA,LobattoIIIC,LobattoIIID,LobattoIIIE,LobattoIIIF,Newton,QinZhang,RK4,RK416,RK438,RadauIA,RadauIIA,Ralston2,Ralston3,Runge2,SRK3,SSPRK3,SymplecticEulerA,SymplecticEulerB,integrateFixed test file imports in
test/runtests.jl:solve,ReturnCode, andSecondOrderODEProblemfromDiffEqBaseAdded ExplicitImports.jl tests to prevent regression:
test/explicit_imports_test.jlwith tests for implicit and stale importsExplicitImportsto test dependencies inProject.tomltest/runtests.jlBenefits:
Testing:
All tests pass, including:
cc @ChrisRackauckas
🤖 Generated with Claude Code