Add CI to build SVGs with images embedded#31
Open
Rongronggg9 wants to merge 3 commits intoSchweinepriester:mainfrom
Open
Add CI to build SVGs with images embedded#31Rongronggg9 wants to merge 3 commits intoSchweinepriester:mainfrom
Rongronggg9 wants to merge 3 commits intoSchweinepriester:mainfrom
Conversation
Owner
|
Thank you for the PR and the inspiration! |
Contributor
Author
|
Sure. Looking forward to the finished SVGs. The current "testing" ones are already impressive for me :) |
paulbull704
approved these changes
Jun 20, 2022
paulbull704
left a comment
paulbull704
left a comment
There was a problem hiding this comment.
I do not know whats going on here.paul
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
|
@Schweinepriester Any chance to remove and block some of these messages and users? 🥲 |
|
O que está havendo ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It should help fix the "CORS" (actually CSP, not CORS) issue mentioned in #30 (comment).
Preview: https://github.com/Rongronggg9/github-profile-achievements/tree/dist
It is believed to be the only solution to work around the CSP issue since it is chosen by opencollective to render user avatars in contributor tables.