Added sort by name and generate icon list option#40
Open
furkankurt wants to merge 2 commits intoScerIO:masterfrom
Open
Added sort by name and generate icon list option#40furkankurt wants to merge 2 commits intoScerIO:masterfrom
furkankurt wants to merge 2 commits intoScerIO:masterfrom
Conversation
Author
|
Hello @SergeShkurko, can you please review this package's Pull Requests? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I needed an icon list and my generated font class didn't sort by icon names.
That's why I wanted to contribute and develop the package.
I've also added the tests for sort and list options.
Please let me know if anything missing.