Fix ecs_import MODULE_UNDEFINED assert when loading modules dynamically#2072
Open
bg5sbk wants to merge 1 commit into
Open
Fix ecs_import MODULE_UNDEFINED assert when loading modules dynamically#2072bg5sbk wants to merge 1 commit into
bg5sbk wants to merge 1 commit into
Conversation
The second lookup in ecs_import() used the raw module_name (PascalCase) instead of the converted path (dot.separated). This caused ecs_import_from_library() to always fail with MODULE_UNDEFINED because ECS_MODULE registers the entity with the dot-separated path (e.g. 'physics.plugin'), but the post-import lookup searched for the PascalCase name (e.g. 'PhysicsPlugin') which doesn't exist. Fix: use the already-converted 'path' variable for both lookups, and defer ecs_os_free(path) to the end of the function. Fixes SanderMertens#2071 Fixes SanderMertens#1755
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The second lookup in ecs_import() used the raw module_name (PascalCase) instead of the converted path (dot.separated). This caused ecs_import_from_library() to always fail with MODULE_UNDEFINED because ECS_MODULE registers the entity with the dot-separated path (e.g. 'physics.plugin'), but the post-import lookup searched for the PascalCase name (e.g. 'PhysicsPlugin') which doesn't exist.
Fix: use the already-converted 'path' variable for both lookups, and defer ecs_os_free(path) to the end of the function.
Fixes #2071
Fixes #1755