Treat compilation warnings as errors on all CI platforms#70
Open
DAflamingFOX wants to merge 1 commit intoSFML:masterfrom
Open
Treat compilation warnings as errors on all CI platforms#70DAflamingFOX wants to merge 1 commit intoSFML:masterfrom
DAflamingFOX wants to merge 1 commit intoSFML:masterfrom
Conversation
Contributor
|
I'm not sure about this - While I agree it's generally a good idea to treat warnings as errors, I'm not sure that's a decision we should be making for users as part of this template, and indeed it's not something we suggest in any of the other SFML setup tutorials, so why would we do it here? Also this only applies it on CI runs so when building locally they will get different results which isn't ideal |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #69.