Tweaked language on descriptions.#39
Open
rzellem wants to merge 3 commits intoRomanSpaceTelescope:developfrom
Open
Tweaked language on descriptions.#39rzellem wants to merge 3 commits intoRomanSpaceTelescope:developfrom
rzellem wants to merge 3 commits intoRomanSpaceTelescope:developfrom
Conversation
Collaborator
|
Question: for the prism, the original description said per pixel, so that makes sense to me to add extra clarity. For the grism, it did not say per pixel, it said for a "(2-pixel resolving power) point source," so are we sure these are values per pixel or per resolution element? |
Collaborator
Author
|
Hmm...yeah this is a little confusing, tbh. @jschlieder - what do you think? |
jschlieder
approved these changes
Jun 5, 2025
jschlieder
reviewed
Jun 5, 2025
| # - {name: wavelength, unit: um, datatype: float64, description: wavelength in microns} | ||
| # - {name: fline_point, unit: erg / (cm*cm) / s, datatype: float64, description: 5-sigma detection limit for a 1-hour exposure time with zodiacal light background at twice the minimum intensity for a (2-pixel resolving power) point source's emission line's integrated flux in units of 1E-17 ergs/cm^2/sec.} | ||
| # - {name: mAB_point, unit: ABmag, datatype: float64, description: 5-sigma detection limit for a 1-hour exposure time with zodiacal light background at twice the minimum intensity for a (2-pixel resolving power) point source's continua in units of AB magnitude at which S/N=5 per pixel.} | ||
| # - {name: mAB_point, unit: ABmag / pix, datatype: float64, description: 5-sigma (per pixel) detection limit for a 1-hour exposure time with zodiacal light background at twice the minimum intensity for a (2-pixel resolving power) point source's continua in units of AB magnitude per pixel.} |
Collaborator
There was a problem hiding this comment.
I have some confusion on whether the mAB limit for point sources needs to include the "(2-pixel resolving power)" statement. It seems that for point sources the limiting magnitude calculation was done per-pixel.
| # - {name: mAB_point, unit: ABmag / pix, datatype: float64, description: 5-sigma (per pixel) detection limit for a 1-hour exposure time with zodiacal light background at twice the minimum intensity for a (2-pixel resolving power) point source's continua in units of AB magnitude per pixel.} | ||
| # - {name: fline_galaxy, unit: erg / (cm*cm) / s, datatype: float64, description: 5-sigma detection limit for a 1-hour exposure time with zodiacal light background at twice the minimum intensity for a compact galaxy's (with half-light radius of 0.3 arcseconds) emission line's integrated flux in units of 1E-17 ergs/cm^2/sec.} | ||
| # - {name: mAB_galaxy, unit: ABmag, datatype: float64, description: 5-sigma detection limit for a 1-hour exposure time with zodiacal light background at twice the minimum intensity for a compact galaxy's (with half-light radius of 0.3 arcseconds) continua in units of AB magnitude at which S/N=5 per pixel.} | ||
| # - {name: mAB_galaxy, unit: ABmag / pix, datatype: float64, description: 5-sigma (per pixel) detection limit for a 1-hour exposure time with zodiacal light background at twice the minimum intensity for a compact galaxy's (with half-light radius of 0.3 arcseconds) continua in units of AB magnitude per pixel.} |
Collaborator
There was a problem hiding this comment.
Same confusion here, I am not sure if the unit should be ABmag/pix or ABmag/2 pix or something similar for this extended galaxy. Might have to reach out to James Rhodes for clarification since he put this part of the Grism performance table together.
Member
|
@rzellem is this PR on hold? |
Collaborator
Author
|
Yes, @mrtommyb - waiting on the input from James Rhodes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To address issue #17