Add CI build job to reduce broken main#969
Add CI build job to reduce broken main#969randavidovitz wants to merge 7 commits intoRightNow-AI:mainfrom
Conversation
jaberjaber23
left a comment
jaberjaber23
left a comment
There was a problem hiding this comment.
LGTM. Good addition of cross-platform build verification. The audit ignore for RUSTSEC-2026-0049 is appropriately documented (rumqttc upstream). Please rebase on main.
|
This PR has merge conflicts. Please rebase onto the latest main branch and resolve conflicts so we can merge. |
randavidovitz
force-pushed
the
ci/add-build-job
branch
from
d3e2275 to
a87bf48
Compare
|
@jaberjaber23 this indicated "1 workflow awaiting approval" |
Following rebase on head needed to fixed failure of checks 1. Formatting 2. Clippy
build is failing on dead code, i decided to add exception (ignore) this since i assume this will be used in later commits
…_arg) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…95/0096)
Resolves 11 wasmtime vulnerabilities including two severity-9 sandbox
escapes (Winch backend and aarch64 Cranelift miscompilation). Adapts
sandbox.rs func_wrap closures to wasmtime 43's split Error type: replaced
anyhow::{bail,anyhow} with wasmtime's re-exported bail!/format_err! and
updated return types from Result<_, anyhow::Error> to wasmtime::Result<_>.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
sorry ... didn't see this one before #1039 ... should be similar and it's based on the latest main. |
|
@jaberjaber23 Would you be able to approve the workflow, so i can merge ? |
|
Thanks @randavidovitz — this PR overlaps heavily with #1039 (both touch The one unique contribution we want to preserve from this PR is the dedicated Ask: once #1039 lands, could you submit a small follow-up PR with only the additive Closing this one in favor of that plan (let me know if you'd rather keep it open and rebase instead — either works). |
3 participants
Summary
buildjob to CI that runscargo build --workspace --libon all 3 platforms (ubuntu, macos, windows)Why
Previously CI only ran
cargo check(type-level validation). Actual compilation errors could slip through. This ensures the code actually compiles before merging.Testing
cargo clippy --workspace --all-targets -- -D warningspassescargo test --workspacepassesSecurity