Skip to content

fix(hands): correct trader dashboard style#1058

Open
lc-soft wants to merge 1 commit intoRightNow-AI:mainfrom
lc-soft:fix/trader-dashboard-style
Open

fix(hands): correct trader dashboard style#1058
lc-soft wants to merge 1 commit intoRightNow-AI:mainfrom
lc-soft:fix/trader-dashboard-style

Conversation

@lc-soft
Copy link
Copy Markdown
Contributor

@lc-soft lc-soft commented Apr 15, 2026

Summary

Fixed two styling issues in the Hands page of the trader dashboard:

  • Content overlap: The absolutely positioned .trader-chart-empty element was incorrectly positioned relative to trader-dashboard, blocking window content and preventing scrolling.
  • Transparent background: The window background appeared transparent due to an undefined --bg-card CSS variable.

Changes

Before After
screenshot-20260415-165705 screenshot-20260415-165647

Testing

  • cargo clippy --workspace --all-targets -- -D warnings passes
  • cargo test --workspace passes
  • Live integration tested (if applicable)

Security

  • No new unsafe code
  • No secrets or API keys in diff
  • User input validated at boundaries

@jaberjaber23
Copy link
Copy Markdown
Member

CSS token rename (--bg-card--surface) + position: relative on .trader-chart — all reasonable. The current CI failures on this PR are pre-existing main breakage (wasmtime CVE fallout), not caused by this diff. Rebasing on main post-#1041 should make the rollup green. Good to land after that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants