feat(embedding): add native Google Gemini embedding driver#1052
Closed
minhnvc wants to merge 1 commit intoRightNow-AI:mainfrom
Closed
feat(embedding): add native Google Gemini embedding driver#1052minhnvc wants to merge 1 commit intoRightNow-AI:mainfrom
minhnvc wants to merge 1 commit intoRightNow-AI:mainfrom
Conversation
Member
|
Thanks @minhnvc — the Gemini embedding driver is something we want, but after comparing with #997 (which landed slightly earlier as a parallel effort) we're going to land #997 as the canonical implementation because it adds:
Your implementation is cleaner and smaller, and the Closing in favor of #997 — not because your code is wrong, just to avoid duplicate review rounds on two nearly-identical drivers. Really appreciate the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GeminiEmbeddingDriverusing thev1betabatchEmbedContentsAPI (not OpenAI-compatible — usesx-goog-api-keyheader)gemini-embedding-001(3072 dims) andtext-embedding-004(768 dims) toinfer_dimensionswarn_external_api()helper to deduplicate the locality-check warning that was copy-pasted between the Gemini and OpenAI-compat branches ofcreate_embedding_driverGEMINI_BATCH_LIMITconst with doc commentConfig
Test plan
cargo build --workspace --lib— clean compile, 0 new warningstest_create_embedding_driver_gemini_requires_api_key— missing key returnsMissingApiKeyGEMINI_API_KEYset, send agent message, verify no embedding warning in logs🤖 Generated with Claude Code