Fix public fields excluded with STJ IncludeFields=true#1907
Merged
lahma merged 1 commit intoRicoSuter:masterfrom Mar 8, 2026
Merged
Fix public fields excluded with STJ IncludeFields=true#1907lahma merged 1 commit intoRicoSuter:masterfrom
lahma merged 1 commit intoRicoSuter:masterfrom
Conversation
lahma
force-pushed
the
fix/include-fields-stj-1680
branch
from
7f09fda to
5d90195
Compare
Respect SerializerOptions.IncludeFields and JsonIncludeAttribute when deciding whether to include fields in schema generation. Previously fields required DataMemberAttribute regardless of STJ settings. Co-Authored-By: Claude Opus 4.6 <[email protected]>
lahma
force-pushed
the
fix/include-fields-stj-1680
branch
from
5d90195 to
f2501cd
Compare
This was referenced Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SystemTextJsonReflectionServicerequired[DataMember]on fields, ignoringSerializerOptions.IncludeFieldsand[JsonInclude]IncludeFields = trueand[JsonInclude]attribute on fieldsTest plan
IncludeFields = true→ field is in schemaIncludeFields→ field is NOT in schema[JsonInclude]→ field is in schema regardless ofIncludeFields🤖 Generated with Claude Code