Ultimate Magic Card support in the CLI#335
Ultimate Magic Card support in the CLI#335suut wants to merge 2 commits intoRfidResearchGroup:mainfrom
Conversation
|
You are welcome to add an entry to the CHANGELOG.md as well |
Built artifacts for commit 9fac740FirmwareClient |
| def exit(self, status: int = 0, message: Union[str, None] = None): | ||
| if message: | ||
| raise ParserExitIntercept(message) | ||
| raise ParserExitIntercept(message) |
There was a problem hiding this comment.
This fixes the bug it would show twice the --help of some commands
LupusE
left a comment
LupusE
left a comment
There was a problem hiding this comment.
I don't own an 'Ultimate Magic Card' (Gen4). But the worst what could happen from reviewing the code: we have a card that should work, but doesn't ...
Maybe there will be a merge conflict with the double-help fix. This should be an own PR
|
Thanks, I need to revisit this a bit and add the rest of the missing code; I have a new version UMC to test with but not the old version; but the differences are minimal and already taken into account by the script I'll split into another PR the help fix |
|
Thanks a lot for your update. |
|
T55xx clone by nieldk · Pull Request #401 · RfidResearchGroup/ChameleonUltragithub.comSent from my iPhoneOn 12 Apr 2026, at 19.21, Benjamin Møller ***@***.***> wrote:LupusE left a comment (RfidResearchGroup/ChameleonUltra#335)
Thanks a lot for your update.
For the double-help fix: I just saw @nieldk mentioned it a couple days ago with a fix. If you both coordinate the PRs, it should be fine. We just need to keep an eye on this.
If we reduce 2 help messages 2 times -> 2-(2x1) = 0 ... We have no help in the end. Pure math :P
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
3 participants
No description provided.