Conversation
…ceNamespace When a pool provisions a namespace it copies secrets from the pool's defaultSecretSourceNamespace. If a NamespaceReservation then specifies the same secretSourceNamespace, CopySecretsFrom would try to cl.Create each secret and fail with 'already exists', blocking assignment indefinitely. Add an 'overwrite bool' parameter to CopySecretsFrom. When true (used when the reservation explicitly provides a secretSourceNamespace), any secret that already exists in the target namespace is deleted and re-copied from the source so the reservation's intent is honoured. When false (pool provisioning), an already-existing secret is treated as a no-op success. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
bsquizz
deleted the
fix/overwrite-secrets-on-reservation-source-override
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
defaultSecretSourceNamespaceinto itNamespaceReservationthen specifies the samesecretSourceNamespace,CopySecretsFromcalledcl.Createon each secret and failed withalready exists, blocking namespace assignment indefinitely via exponential backoffbonfire-reservation-1b23c25aspent ~10 minutes retrying before finally assigning due to an unrelated code path, then immediately expiredFix
Added an
overwrite boolparameter toCopySecretsFrom:overwrite=false(pool provisioning): if a secret already exists in the target namespace, treat it as a no-op success — the pre-provisioned copy is fineoverwrite=true(reservation with explicitsecretSourceNamespace): delete the existing copy and re-create from the specified source — the reservation's intent overrides whatever was pre-populatedTest plan
make fmt vet— cleanmake test— 93/93 tests pass (53 helper + 40 controller)🤖 Generated with Claude Code